Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too long resource name #124

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

massi-ang
Copy link
Collaborator

Issue #, if available:
Fix #122

Description of changes:
Nested CDK constructs names get concatenated and if no resource name is specified in the construct the CDK construct name is used. This might cause some resource identifiers, such as ARNs to exceed the allowed length.
This fix reduces the length of few known resources.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

for multi model enpoints uses an hash of the model names
@massi-ang massi-ang requested a review from spugachev October 20, 2023 08:57
@bigadsoleiman bigadsoleiman merged commit 360c615 into aws-samples:main Oct 20, 2023
@massi-ang massi-ang deleted the fix_too_long_resource_name branch October 20, 2023 09:24
@jlchavez78
Copy link

Hi,
It's working perfect now.
Thanks.

Best regards :)

lloydclowes pushed a commit to lloydclowes/gen-ai-playground that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CDK Creation Failed
3 participants